[WIP] snake_case #617
Closed
[WIP] snake_case #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
reviewed
Apr 3, 2025
| // Set to a positive number to have a cache of that size. | ||
| const int MAX_CONTEXTS_PER_GPU_IN_CACHE = -1; | ||
| std::vector<AVBufferRef*> g_cached_hw_device_ctxs[MAX_CUDA_GPUS]; | ||
| std::vector<_avbuffer_ref*> g_cached_hw_device_ctxs[MAX_CUDA_GPUS]; |
Contributor
There was a problem hiding this comment.
AVBufferRef should remain Pascal case
scotts
reviewed
Apr 3, 2025
| } else { | ||
| dst = allocateEmptyHWCTensor(height, width, videoStreamOptions.device); | ||
| dst = | ||
| allocate_empty_h_w_c_tensor(height, width, video_stream_options.device); |
Contributor
There was a problem hiding this comment.
Here and below, I'd find it easier if we wrote this as allocate_empty_hwc_tensor() and nppi_nv12_to_rgb_8u_p2c3r(). Basically, we'll want to be careful about how to turn a sequence of all caps into snake case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.